Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use dist-tag to add latest tag to canary #83

Merged
merged 1 commit into from
Feb 11, 2023

Conversation

baked-dev
Copy link
Member

No description provided.

@baked-dev baked-dev requested a review from Wyatt-SG as a code owner February 11, 2023 03:46
@linear
Copy link

linear bot commented Feb 11, 2023

INFRA-25 fix check action

I mistakenly assumed that you can add multiple tags in the npm publish command. As a result of that once 2 canary versions are released the check action will incorrectly pick up a new release of the module when pushing to the repo (canary is -canary.0, latest is -canary.1, when a regular commit is added it will fetch the latest canary version in canary.0 and assume it can publish canary.0 resulting in the release action to fail.

  • fixing by using pnpm dist-tag in the release action to add the latest label to "latest-canary" versions

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2023

Unimported Action report

Summary

Project Status Unused Deps Unresolved Deps Unimported Files
packages/action - - -
packages/create-turbo-module - - -
packages/turbo-module - - -

@baked-dev baked-dev changed the title use dist-tag to add latest label to canary use dist-tag to add latest tag to canary Feb 11, 2023
@baked-dev baked-dev merged commit d5ef2c2 into main Feb 11, 2023
@kodiakhq kodiakhq bot deleted the tristan/infra-25-fix-check-action branch February 11, 2023 03:47
kodiakhq bot pushed a commit that referenced this pull request Feb 11, 2023
### Core Changes

- use dist-tag to add latest tag to canary (#83)

### Credits
@baked-dev
kodiakhq bot pushed a commit that referenced this pull request May 15, 2023
### Action Changes

- log current version in check action (#80)

### Core Changes

- use dist-tag to add latest tag to canary (#83)

### Create-turbo-module Changes

- Update READMEs (#86)

### Credits
@baked-dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant