Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin eslint version in CI #93

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

sergeichestakov
Copy link
Contributor

CI is currently red in this repo if you try to open a PR or commit to main because we implicitly download the latest version of eslint (major version 9) which has since been deprecated and no longer supports the eslint config file format we still use (bc this repo is old).

If we pin the version to the latest major version 8, it finally works again so we can land PRs again.

@sergeichestakov sergeichestakov self-assigned this Jun 15, 2024
Copy link
Contributor

github-actions bot commented Jun 15, 2024

Unimported Action report

Summary

Project Status Unused Deps Unresolved Deps Unimported Files
packages/action - - -
packages/create-turbo-module - - -
packages/turbo-module - - -

@sergeichestakov
Copy link
Contributor Author

btw @jjantschulev this was the fix in case you're curious ^

@kodiakhq kodiakhq bot merged commit 2fead15 into main Jun 17, 2024
7 checks passed
@kodiakhq kodiakhq bot deleted the @sergeichestakov/pin-eslint-version branch June 17, 2024 17:57
kodiakhq bot pushed a commit that referenced this pull request Jun 17, 2024
### General Changes

- Pin eslint version in CI (#93)

### Action Changes

- Limit length of PR body to GH maximum (#92)

### Credits
@sergeichestakov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants