Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting fixes, npm scripts #698

Merged
merged 8 commits into from
Sep 14, 2021
Merged

Conversation

laurence-myers
Copy link
Contributor

  • package.json:
    • Add npm script check:lint to lint all files per each tsconfig
    • Add npm script check:tsc to type check all files per each tsconfig
    • Add npm script check to run both check:tsc and check:lint
    • Specify engines, NodeJS v14.
  • Auto-fix many linting issues
  • Manually fix some linting issues
    • Rename shadowed variables
    • Replace eval() when calculating frame rate, with string split & explicit division
  • Disable linting for some warnings.
  • .gitignore: Ignore /.idea, added by IntelliJ IDEA

I tried adding a new Workflow to execute check, but it failed to install fsevents. I don't know how to fix this using npm, I suggest replacing npm and package-lock.json with yarn and yarn.lock, which behaves better across different systems.

Failing CI step

@whyboris
Copy link
Owner

Thank you for the contribution! I'll try to find time in the near future to test-drive it 😉 merge this in 🤝

@whyboris
Copy link
Owner

I'm loving this 😍
Thank you very much!

Copy link
Owner

@whyboris whyboris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉
Thank you 🙇
So good 🤩

@whyboris whyboris merged commit 6f36eb6 into whyboris:main Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants