added folder "does not have" filter #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry it's been a busy month - I somehow missed this PR 🙇 |
|
Thank you so much @PiantaSE for your contribution 🙇 I'm sorry I'm unsure how we ended up with two PRs resolving the same issue 😓 I should have been more vigilant. I'll merge #772 first, but I see you've caught a few other places where code needed to be updated (e.g. |
whyboris
approved these changes
Oct 31, 2022
|
Thank you for catching all the extra edge cases 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Boris! This was my attempt at adding the filter stated in the Issue. I feel as I have a solid foundation with it so far, but seem to be missing something, and I cannot put my finger on it. I somehow also have made it so the filter for excluding files with based on the inputted word works opposite of its intended functionality. Thank you for all your help! Look forward to working on this more :)