Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: connect everything together #25

Merged
merged 32 commits into from
Dec 18, 2023
Merged

Conversation

timcreatedit
Copy link
Contributor

@timcreatedit timcreatedit commented Nov 27, 2023

Description

Checklist

  • My PR title is in the style of conventional commits
  • All public facing APIs are documented with dartdoc
  • I have added tests to cover my changes

@timcreatedit timcreatedit marked this pull request as draft November 27, 2023 15:24
Copy link
Contributor

github-actions bot commented Nov 27, 2023

Coverage Report

Automatic coverage report for 5d91335c.

Generated by dart-coverage-assistant

Total coverage:

Coverage Diff
warning ⬇️ -2.07%

figmage

A CLI tool for generating Figma styles for Flutter

Coverage Diff
warning ⬇️ -12.89%
Coverage Details for figmage
File Line Percentage Line Count
/home/runner/work/figmage/figmage/lib/src
command_runner.dart 100 62
/home/runner/work/figmage/figmage/lib/src/commands/reforge
reforge_command.dart 100 8
/home/runner/work/figmage/figmage/lib/src/commands/shared
generation_notifier.dart 71.42857142857143 21
forge_settings_providers.dart 93.75 16
/home/runner/work/figmage/figmage/lib/src/commands/update
update_command.dart 57.692307692307686 26
/home/runner/work/figmage/figmage/lib/src/data/generators
color_theme_extension_generator.dart 100 4
values_by_mode_theme_extension_generator.dart 99.40119760479041 167
generator_util.dart 100 12
number_theme_extension_generator.dart 100 2
padding_generator.dart 100 91
spacer_generator.dart 100 84
text_style_theme_extension_generator.dart 95 20
/home/runner/work/figmage/figmage/lib/src/data/repositories
dart_code_file_writer_repository.dart 0 7
dart_post_generation_repository.dart 100 17
figma_styles_repository.dart 23.333333333333332 30
figma_variables_repository.dart 83.65384615384616 104
yaml_config_repository.dart 82.6086956521739 23
/home/runner/work/figmage/figmage/lib/src/data/util/converters
string_dart_conversion_x.dart 100 14
color_conversion_x.dart 0 8
type_style_conversion_x.dart 0 13
/home/runner/work/figmage/figmage/lib/src/domain/models/config
config.dart 72.97297297297297 37
config.g.dart 100 56
/home/runner/work/figmage/figmage/lib/src/domain/models/style
design_style.dart 54.54545454545454 11
/home/runner/work/figmage/figmage/lib/src/domain/models/text_style
text_style.dart 100 1
/home/runner/work/figmage/figmage/lib/src/domain/models/tokens_by_file_type
tokens_by_type.dart 100 1
/home/runner/work/figmage/figmage/lib/src/domain/models/variable
variable.dart 37.5 24
/home/runner/work/figmage/figmage/lib/src/domain/models/variable/alias_or
alias_or.dart 100 4
/home/runner/work/figmage/figmage/lib/src/domain/providers
logger_providers.dart 100 1
pub_updater_providers.dart 100 1
config_providers.dart 100 4
design_token_providers.dart 72.54901960784314 51
figmage_package_generator_providers.dart 15.384615384615385 26
file_writer_providers.dart 22.22222222222222 9
generator_providers.dart 100 53
post_generation_providers.dart 87.5 8
/home/runner/work/figmage/figmage/lib/src/domain/repositories
file_writer_repository.dart 0 2
post_generation_repository.dart 100 2
styles_repository.dart 83.33333333333334 6
variables_repository.dart 40 5
config_repository.dart 100 2
/home/runner/work/figmage/figmage/lib/src/domain/util
token_filter_x.dart 94.11764705882352 17

figma_variables_api

Figma REST API for variables.

Coverage Diff
warning ➡️ 0.00%
Coverage Details for figma_variables_api
File Line Percentage Line Count
/home/runner/work/figmage/figmage/packages/figma_variables_api/lib/src
client.dart 1.7241379310344827 58
query.dart 0 16
/home/runner/work/figmage/figmage/packages/figma_variables_api/lib/src/models/dto/variable
variable_dto.dart 100 17
variable_dto.g.dart 68.91891891891892 74
/home/runner/work/figmage/figmage/packages/figma_variables_api/lib/src/models/dto/variable_collection
variable_collection_dto.g.dart 72.1311475409836 61
variable_collection_dto.dart 100 14
/home/runner/work/figmage/figmage/packages/figma_variables_api/lib/src/models/dto/variable_mode
variable_mode_dto.dart 100 6
variable_mode_dto.g.dart 40 20
/home/runner/work/figmage/figmage/packages/figma_variables_api/lib/src/models/dto/variable_mode_value
variable_mode_value_dto.dart 100 52
variable_mode_value_dto.g.dart 52.63157894736842 38
/home/runner/work/figmage/figmage/packages/figma_variables_api/lib/src/models/dto/variable_response
variables_response_dto.g.dart 37.03703703703704 27
variables_response_dto.dart 100 6
/home/runner/work/figmage/figmage/packages/figma_variables_api/lib/src/models/dto/variables_meta
variables_meta_dto.dart 66.66666666666666 6
variables_meta_dto.g.dart 47.82608695652174 23

figmage_package_generator

A generator for an empty figmage styles dart package

Coverage Diff
pass ⬆️ +6.67%
Coverage Details for figmage_package_generator
File Line Percentage Line Count
/home/runner/work/figmage/figmage/packages/figmage_package_generator/lib/src
token_file_type.dart 100 9
figmage_package_generator.dart 100 17

Tim Lehmann and others added 8 commits November 27, 2023 16:37
* added all kinds of styles

* small fixes

* remove token

* removed test file

* so many changessss

* smaller changes

* many fixes

* added integration test

* delete path

* it generates something!!!

* simplified util
@timcreatedit timcreatedit changed the title feat!: file writer repository and new DI feat!: connect everything together Nov 30, 2023
@timcreatedit timcreatedit marked this pull request as ready for review December 6, 2023 16:36
@@ -92,28 +92,24 @@ abstract class ValuesByModeThemeExtensionGenerator<T>
String generate() {
final validValueMaps = valuesByNameByMode.map(
(key, value) => MapEntry(
convertToValidVariableName(key),
switch (key) {
"" => "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wann passiert denn der case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jaa das ist zugegebenermaßen ein bisschen dumm. Schau mal in design_style.dart den valuesByMode getter an. Der macht das quasi jetzt so weil Styles ja keine Modes haben. Das geht aber bestimmt schlauer, bin offen für Vorschläge

@timcreatedit timcreatedit merged commit 85f1009 into main Dec 18, 2023
@timcreatedit timcreatedit deleted the feat/file-writer-repository branch December 18, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants