Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move confirmationDialog and Menu out of lab #955

Open
wants to merge 1 commit into
base: 12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults
Choose a base branch
from

Conversation

iisakkirotko
Copy link
Collaborator

All Submissions:

Description of changes

Copy link
Collaborator Author

iisakkirotko commented Dec 27, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@iisakkirotko iisakkirotko added this to the Solara 2.0 milestone Dec 27, 2024
@iisakkirotko iisakkirotko force-pushed the 12-23-feat_deprecate_use_thread branch from f16af91 to 6bfa775 Compare January 31, 2025 11:06
@iisakkirotko iisakkirotko force-pushed the 12-27-chore_move_confirmationdialog_and_menu_out_of_lab branch 2 times, most recently from ee9172f to 46d3a8c Compare February 3, 2025 09:52
Copy link
Contributor

@maartenbreddels maartenbreddels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, looks good! The only thing is the redirect for the docs.

@iisakkirotko iisakkirotko force-pushed the 12-23-feat_deprecate_use_thread branch from 6bfa775 to f776b7c Compare February 4, 2025 10:26
@iisakkirotko iisakkirotko force-pushed the 12-27-chore_move_confirmationdialog_and_menu_out_of_lab branch from 46d3a8c to 78bc284 Compare February 4, 2025 10:26
@iisakkirotko iisakkirotko force-pushed the 12-23-feat_deprecate_use_thread branch from f776b7c to d77b641 Compare February 5, 2025 08:14
@iisakkirotko iisakkirotko force-pushed the 12-27-chore_move_confirmationdialog_and_menu_out_of_lab branch from 78bc284 to 3e0dac8 Compare February 5, 2025 08:14
@iisakkirotko iisakkirotko force-pushed the 12-23-feat_deprecate_use_thread branch from d77b641 to 6582fbf Compare February 5, 2025 09:07
@iisakkirotko iisakkirotko force-pushed the 12-27-chore_move_confirmationdialog_and_menu_out_of_lab branch from 3e0dac8 to e9c0e89 Compare February 7, 2025 15:19
@iisakkirotko iisakkirotko changed the base branch from 12-23-feat_deprecate_use_thread to 12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults February 7, 2025 15:20
Copy link
Contributor

@maartenbreddels maartenbreddels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants