Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow disabling mutation detection per reactive instance #984

Open
wants to merge 3 commits into
base: 12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults
Choose a base branch
from
Open

feat: allow disabling mutation detection per reactive instance #984

wants to merge 3 commits into from
+80 −71

Conversation

iisakkirotko
Copy link
Collaborator

@iisakkirotko iisakkirotko commented Jan 23, 2025 •
edited
Loading

All Submissions:

Description of changes

Enables disabling mutation detection for per reactive variable.

Fixes #983

iisakkirotko and others added 3 commits January 21, 2025 09:37
@iisakkirotko
feat!: change mutation_detection and allow_reactive_boolean defaults
b1289ce 
BREAKING CHANGE: an error is now raised if a reactive variable (not its value) is used in boolean comparisons
BREAKIGN CHANGE: mutation detection is now enabled by default
@iisakkirotko
fix!: solara Meta and Navigator elements insert empty span into D…
70e86a3 
…OM (#625)

* fix[docs]: solara.Meta elements insert empty span into DOM

* chore: remove workaround from jupyter notebook tutorial

Reverts #627, since the workaround is no longer needed.

* fix!: navigator would insert an empty span into dom
@iisakkirotko
feat: allow disabling mutation detection per reactive instance
0a7c2f3
@iisakkirotko Graphite App
Copy link
Collaborator Author

iisakkirotko commented Jan 23, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@iisakkirotko iisakkirotko force-pushed the 12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults branch 3 times, most recently from a97b75b to 1d29010 Compare February 5, 2025 09:06
@iisakkirotko iisakkirotko force-pushed the 12-23-feat_change_mutation_detection_and_allow_reactive_boolean_defaults branch from 0cef192 to 2bd9071 Compare February 7, 2025 15:19
@iisakkirotko iisakkirotko added this to the Solara 2.0 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Solara 2.0
Development

Successfully merging this pull request may close these issues.
1 participant
@iisakkirotko