Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: twitter/og meta tags weren't present on most pages #998

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −4
Open

docs: twitter/og meta tags weren't present on most pages #998

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions solara/website/pages/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ def Layout(children=[]):
target, set_target = solara.use_state(0)

if route_current is not None:
with solara.Div(style={"display": "none"}):
with solara.Head():
solara.Meta(name="twitter:card", content="summary_large_image")
solara.Meta(name="twitter:site", content="@solara_dev")
solara.Meta(name="twitter:image", content="https://solara.dev/static/assets/images/logo-small.png")
Expand All @@ -265,7 +265,7 @@ def Layout(children=[]):
Title(title="Solara: Build high-quality web applications in pure Python")
Home()
else:
with solara.VBox(grow=False) as main:
with solara.VBox(grow=False):
Title(title="Solara documentation")
Header(
on_toggle_left_menu=lambda: set_show_left_menu(not show_left_menu),
Expand Down Expand Up @@ -344,8 +344,6 @@ def Layout(children=[]):
):
route_current.module.Sidebar()

return main


@solara.component
def Testimonial(text, name, position, img):
Expand Down
Loading