Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding campaign events extension to pixel #161

Merged
merged 3 commits into from
Jan 28, 2023

Conversation

vaughnwalters
Copy link
Collaborator

Adding the Campaign Events extension to the pixel list of repositories. The repo successfully clones into pixel and I am able to open the extension from local port 3000

@nicholasray nicholasray self-requested a review January 27, 2023 17:45
@nicholasray
Copy link
Contributor

nicholasray commented Jan 27, 2023

Looks great @vaughnwalters !

The only thing I noticed is that because the CampaignEvents extension reportedly adds tables the database, we'll want to update the seed data that Pixel uses in this PR as well.

I've already followed the steps in https://github.com/wikimedia/pixel-seed-data to add the new file, all that is left is to change the following line in Dockerfile.database to:

ARG database="database_2023-01-27_13-42-07-0700(MST).tar.gz"

After that, I think it's good to go!

@vaughnwalters
Copy link
Collaborator Author

Ah, okay thank you for that! I wasn't sure if it meant to update that pixel seed data repo if there was data added to the DB, or if there were schema changes. I just pushed the updated line to the Dockerfile.database file to this PR

@nicholasray nicholasray merged commit 11da14e into wikimedia:main Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants