Revise node version in mediawiki docker image and npm scripts #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use node on debian buster to match the php72-fpm image. * Revise `npm run db:save` to use docker compose instead of docker run now that the database is a service. * As a result of the preceding point, naming the dbdata volume becomes unnecessary
nicholasray
force-pushed
the
revise-mediawiki-docker-image-and-npm-scripts
branch
from
ca5a7d3 to
2763f49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use node on debian buster to match the php72-fpm image.
Revise
npm run db:saveto use docker compose instead of docker run now thatthe database is a service.