Switch PNG optimizer to not happen on png creation #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now this script kicks it off for all pngs: optimize-pngs.sh Fixes issue of screenshot optimizations sometimes overlapping with backstopJS image comparison Also makes png containers ephemeral Runs optimizations in parallel, scaling with processor core count Preserves checks for if images have already been optimized No need to use the optimization script when developing locally. Will be triggered once a day on the server via cron for now
|
Just ran on the server and it took 982 seconds, or about 16.4 minutes to optimize all of our backstopJS images The cron has been updated to run this once daily on a schedule that should keep it from happening when any backstopJS image comparisons are being done, and before we run our archive script |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now this script kicks it off for all pngs:
optimize-pngs.shhttps://phabricator.wikimedia.org/T366981