-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable animations for UI regression runs #5
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
55ca797
Disable animations for UI regression runs
jdlrobson 911b623
Update src/engine-scripts/puppet/jsReady.js
jdlrobson 2f80b61
Use setInterval to evaluate
jdlrobson ed405db
Wrap rAF in page.evaluate callback
3378f7b
Revise rAF statement
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
module.exports = async (page) => { | ||
await page.emulateMediaFeatures([ | ||
{ name: 'prefers-reduced-motion', value: 'reduce' }, | ||
]); | ||
await page.evaluate( () => { | ||
const skin = mw.config.get( 'skin' ); | ||
let moduleName; | ||
switch( skin ) { | ||
case 'vector-2022': | ||
moduleName = 'skins.vector.js'; | ||
break; | ||
case 'vector': | ||
moduleName = 'skins.vector.legacy.js'; | ||
break; | ||
default: | ||
return true; | ||
} | ||
return new Promise((resolve) => { | ||
setInterval(() => { | ||
if ( mw.loader.getState( moduleName ) === 'ready' ) { | ||
resolve(true); | ||
} | ||
}, 500 ); | ||
}); | ||
}); | ||
|
||
// wait for animation frame or two. | ||
// Wait until the next frame before resolving. | ||
await new Promise( resolve => { | ||
requestAnimationFrame( () => { | ||
requestAnimationFrame( () => { | ||
resolve(); | ||
} ); | ||
} ); | ||
} ); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is currently throwing an error because it needs to go in a
page.evaluate
, but I'm also wondering if it's needed at this point? Can it be removed or have you had issues without it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even with the removal of animations we still use requestAnimationFrame for the resize to get it off the critical path so I think this is needed to be 100% sure. Moving it into the evaluate is obviously needed, that's my bad.
I'm wrapping up for the day so feel free to amend while I am out. If not I'll pick this up Monday.