Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable animations for UI regression runs #5

Merged
merged 5 commits into from
Apr 21, 2022
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions src/engine-scripts/puppet/jsReady.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
module.exports = async (page) => {
await page.emulateMediaFeatures([
{ name: 'prefers-reduced-motion', value: 'reduce' },
]);
await page.evaluate( () => {
const skin = mw.config.get( 'skin' );
let moduleName;
switch( skin ) {
case 'vector-2022':
moduleName = 'skins.vector.js';
break;
case 'vector':
moduleName = 'skins.vector.legacy.js';
break;
default:
return true;
}
return new Promise((resolve) => {
setInterval(() => {
if ( mw.loader.getState( moduleName ) === 'ready' ) {
resolve(true);
}
}, 500 );
});
});

// wait for animation frame or two.
// Wait until the next frame before resolving.
await new Promise( resolve => {
requestAnimationFrame( () => {
requestAnimationFrame( () => {
resolve();
} );
} );
} );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently throwing an error because it needs to go in a page.evaluate, but I'm also wondering if it's needed at this point? Can it be removed or have you had issues without it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even with the removal of animations we still use requestAnimationFrame for the resize to get it off the critical path so I think this is needed to be 100% sure. Moving it into the evaluate is obviously needed, that's my bad.

I'm wrapping up for the day so feel free to amend while I am out. If not I'll pick this up Monday.

};
3 changes: 3 additions & 0 deletions src/engine-scripts/puppet/onReady.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,8 @@ module.exports = async (page, scenario, vp) => {
await require('./sidebarState')(page, hashtags);
await require('./userMenuState')(page, hashtags);
}

// Make sure the main skin JavaScript module has loaded.
await require('./jsReady')(page);
// add more ready handlers here...
};