Fix flaky scroll #80
Merged
Fix flaky scroll #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasray
force-pushed
the
fix-flaky-scroll
branch
2 times, most recently
from
6ec5df0 to
05d38e4
Compare
Sometimes the MediaWiki_Test_sticky_header_vector-2022_logged-in_scroll test fails. I think what might be happening is that the animation has not completed yet when the screenshot is taken. If this is the case, fast forward through any animations.
nicholasray
force-pushed
the
fix-flaky-scroll
branch
from
05d38e4 to
6de0e9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the MediaWiki_Test_sticky_header_vector-2022_logged-in_scroll
test fails. I think what might be happening is the animation has
completed yet when the screenshot is taken. If this is the case, fast
forward through any animations.