Dp/language translations & Copy #25
Conversation
DenhamPreen
commented
Nov 8, 2019
DenhamPreen
commented
- muggle crypto translations
- swapped video with simpler copy
- tooltips on gorilla views
| @@ -367,4 +374,4 @@ let mergeStyles: list(string) => string = | |||
| styles => { | |||
| /* styles->Belt.List.reduce("", mapStylesFunction);*/ | |||
| styles->Belt.List.reduce("", (prev, next) => prev ++ " " ++ next); | |||
| }; | |||
| }; | |||
There was a problem hiding this comment.
@DenhamPreen We should get our editor settings more aligned. Mine adds a trailing newline on all files. I personally prefer this since it means that it is easier to add new things to this file when editing.
| <React.Fragment> | ||
| <h1 className=Styles.heading> | ||
| <span className=Styles.colorBlue> <S> "Always for sale" </S> </span> | ||
| <br /> | ||
| <S> "ethereum based" </S> | ||
| <S> {translation(. "ethereum") ++ " based"} </S> |
There was a problem hiding this comment.
We can switch this to use reason string templates {j|@$variable1 some tex $variable2 .|j}
| <small> | ||
| <strong> | ||
| <S> {"Monthly Pledge (at " ++ monthlyRate ++ "%):"} </S> | ||
| <S> {"Monthly Pledge (at " ++ monthlyRate ++ "%): "} </S> | ||
| <Rimble.Tooltip |
There was a problem hiding this comment.
We should look into why we couldn't add little info icons here: #26
| import UbisoftLogo from '../../img/logos/Ubisoft.png' | ||
| import EthCapeTownLogo from '../../img/logos/EthCapeTown.png' | ||
| import WildTomorrowFundLogo from '../../img/logos/WildTomorrowFund.png' | ||
| import React from "react"; |
There was a problem hiding this comment.
We need to get a linter for all wildcards code, @DenhamPreen
| value={{ | ||
| translationModeCrypto, | ||
| settranslationModeCrypto, | ||
| translationMode: translationModeCrypto ? "crypto" : "muggle" |
There was a problem hiding this comment.
When we move this to Reason we can create a variant type for this, it will make the code nice and elegant, for sure :)
https://reasonml.github.io/docs/en/variant
There was a problem hiding this comment.
Nothing to change, just a few small comments of things to look at in the future @DenhamPreen
| </span> | ||
| <ReactTranslate.Switch | ||
| onChange={ | ||
| usedtranslationModeContext->settranslationModeCrypto |
There was a problem hiding this comment.
settranslationModeCrypto -> setTranslationModeCrypto
