[EJBCLIENT-253] Emulate org.jboss.ejb.client.EJBClientContext.registe… #307
Conversation
| * @return a handle which may be used to later remove this registration | ||
| * @throws IllegalArgumentException if the given interceptor is {@code null}, the priority is less than 0, or the | ||
| * given interceptor is already registered with a different priority | ||
| * @deprecated |
There was a problem hiding this comment.
An explanation for the deprecation should be made here. Also, as a matter of convention I also add the @Deprecated annotation.
There was a problem hiding this comment.
There is also a problem that if an interceptor is added or removed after a proxy is used, the proxy will not see the update because proxy interceptor information is cached by way of the org.jboss.ejb.client.EJBClientContext#proxyInfoValue field. This might be OK (since this is just a compatibility method) but should be documented in any event.
|
|
||
| /** | ||
| * An interceptor registration handle. | ||
| * @deprecated |
There was a problem hiding this comment.
A deprecation description would be useful here too.
…rInterceptor(ILorg/jboss/ejb/client/EJBClientInterceptor;)
|
@dmlloyd Thank you for the review, I have updated with your request changes, please review it again. Thank you very much ! :) |
…rInterceptor(ILorg/jboss/ejb/client/EJBClientInterceptor;)
Jira: https://issues.jboss.org/browse/EJBCLIENT-253