-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFLY-13023] Upgrade MicroProfile Config 1.4 #285
[WFLY-13023] Upgrade MicroProfile Config 1.4 #285
Conversation
8761b21
to
c8b27d1
Compare
c8b27d1
to
dcf9854
Compare
|
||
* Run the WildFly integration basic test suite and checks there are no failures related to MicroProfle Config tests. | ||
* Run the `microprofile-tck/config` module from WildFly integration test suite and checks that there are no failures. | ||
* Some tests that relates to the https://github.com/eclipse/microprofile-config/issues/446[inconsistent behaviour for empty/missing config property (#446)] are excluded as smallrye-config implementation does not pass the TCK tests that are challenged by this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smallrye-config implementation does not pass the TCK tests
@jmesnil Can you please share more details about this? Which tests doesn't pass? I don't see any ignored tests in WF TS. Does this means that new SmallRye Config 1.6.1 is not compliant with MP Config 1.4?
Some tests that relates to the https://github.com/eclipse/microprofile-config/issues/446[inconsistent behaviour for empty/missing config property (#446)] are excluded ...
Can you please share list of these tests?
I'm looking to this issue and it seems that there is no conclusion about future behaviour.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marekkopecky, test excluded from the MP config TCK are configured in https://github.com/wildfly/wildfly/blob/3af5d5438457bc2697ffc59118e7d5ce247f875d/testsuite/integration/microprofile-tck/config/tck-suite.xml#L11
The discussion in microprofile/microprofile-config#446 is ongoing will not be resolved before MP Config 2.0 is released
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I check WF TS and SmallRye TS (1.6.1). Excluded TCK tests fails in both these TSs
JIRA: https://issues.redhat.com/browse/WFLY-13023 Signed-off-by: Jeff Mesnil <[email protected]>
dcf9854
to
5d9e1db
Compare
@jmesnil Thank you for your updates. |
JIRA: https://issues.redhat.com/browse/WFLY-13023
Signed-off-by: Jeff Mesnil [email protected]