Add option to strip EXIF profiles #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
I'll try to come up with a test for this feature. |
|
Hey, thanks so much for submitting this! The code looks good to me; I'll just test it out on a couple of sites and then hopefully get a new version of the Gem out this week 😄 |
|
This is in v1.5.0 of the gem. Thanks a bunch @driehuis! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementations of ImageMagick differ in whether or not they strip EXIF profiles by default, so this pull request may not be relevant to all users (then again, it won't hurt either).
This pull request adds an option to call img.strip! before saving the resized image. In my use case, this strips about 15% of the average size of the images on my website. For users of Adobe products that secretly stash a copy of Websters Dictionary in each saved image, the savings would be even greater.
The preservation of EXIF data is hit or miss anyway, so a case could even be made to make strip be true by default. But I'm not sure if there are use cases for EXIF on the web, so I made strip false by default to minimize the risk of surprises.