Use UrlGeneratorInterface constants for UrlGenerator::generate

For relative path (with absolute url) use Symfony\Component\Routing\Generator\UrlGeneratorInterface::ABSOLUTE_PATH
willdurand · Jan 19, 2016 · 7555ea6 · 7555ea6 · ggioffreda · Feb 25, 2016
1 parent 2733268
commit 7555ea6
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/Hateoas/UrlGenerator/SymfonyUrlGenerator.php b/src/Hateoas/UrlGenerator/SymfonyUrlGenerator.php
@@ -24,6 +24,14 @@ public function __construct(SymfonyUrlGeneratorInterface $urlGenerator)
      */
     public function generate($name, array $parameters, $absolute = false)
     {
+        // If is it at least Symfony 2.8 and $absolute is passed as boolean
+        if (SymfonyUrlGeneratorInterface::ABSOLUTE_PATH === 1 && is_bool($absolute)) {
+            $absolute = $absolute
+                ? SymfonyUrlGeneratorInterface::ABSOLUTE_URL
+                : SymfonyUrlGeneratorInterface::ABSOLUTE_PATH
+            ;
+        }
+
         return $this->urlGenerator->generate($name, $parameters, $absolute);
     }
 }
diff --git a/tests/Hateoas/Tests/UrlGenerator/SymfonyUrlGeneratorTest.php b/tests/Hateoas/Tests/UrlGenerator/SymfonyUrlGeneratorTest.php
@@ -14,6 +14,10 @@ public function test()
         $absolute       = true;
         $expectedResult = '/users/42';
 
+        if (\Symfony\Component\Routing\Generator\UrlGeneratorInterface::ABSOLUTE_PATH === 1) {
+            $absolute = \Symfony\Component\Routing\Generator\UrlGeneratorInterface::ABSOLUTE_URL;
+        }
+
         $symfonyUrlGeneratorProphecy = $this->prophesize('Symfony\Component\Routing\Generator\UrlGeneratorInterface');
         $symfonyUrlGeneratorProphecy
             ->generate($name, $parameters, $absolute)