Embedded relation should inherit exclusion

[sroze]

When I set groups in the exclusion strategy of a relation, the embedded is never generated.

/**
 * @Hateoas\Relation(
 *     "user",
 *     href = "expr('/api/user/' ~ object.getUser().getId())",
 *     embedded = "expr(object.getUser())",
 *     exclusion = @Hateoas\Exclusion(
 *         excludeIf = "expr(object.getUser() === null)",
 *         groups={"travel"}
 *     )
 * )
 */

It's because the ExclusionManager call the shouldSkipProperty method of JMS's GroupsExclusionStrategy with the embedded exclusion. In that case, the exclusion of embedded is empty, so these tests fail, so this relation is not embedded.

The only way to make it working is to repeat the exclusion on the embedded:

/**
 * @Hateoas\Relation(
 *     "user",
 *     href = "expr('/api/user/' ~ object.getUser().getId())",
 *     embedded = @Hateoas\Embedded(
 *         "expr(object.getUser())",
 *         exclusion = @Hateoas\Exclusion(
 *             groups={"travel"}
 *         )
 *     ),
 *     exclusion = @Hateoas\Exclusion(
 *         excludeIf = "expr(object.getUser() === null)",
 *         groups={"travel"}
 *     )
 * )
 */

That's why I think that embedded should inherit from relation exclusion when there's no specified on it.

[adrienbrault]

This makes sense