Evaluate ExcludeIf after JMS exclusion strategy #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enhance the perf of the ExclusionManager. Most of all JMS ExclusionStrategyInterface relies on counter, isset and other basic language functionalities, while the evaluator allows to instantiate service or triggers voter through isGranted. Evaluating this code whereas simple checks like groups or version already exclude adds a significant overhead. This change inverts the order of the execution.
|
Looks good! 👍 |
willdurand
added a commit
that referenced
this pull request
Sep 9, 2015
Evaluate ExcludeIf after JMS exclusion strategy
|
thanks |
|
Thanks for this fast merge! |
|
Need a new version? |
|
Yes please ;) |
|
Here it is: 2.8.0! |
|
Thanks ;) |
|
👯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enhance the perf of the ExclusionManager.
Most of all JMS ExclusionStrategyInterface relies on counter, isset and other basic language functionalities, while the evaluator allows to instantiate service or triggers voter through isGranted.
Evaluating this code whereas simple checks like groups or version already exclude adds a significant overhead.
This change inverts the order of the execution.