Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expressions in attributes are not supported when using YAML. #297

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Expressions in attributes are not supported when using YAML. #297

merged 1 commit into from
Sep 9, 2019

Conversation

phpeek
Copy link

@phpeek phpeek commented Sep 8, 2019 •
edited
Loading

Looks like this was not supported and not being evaluated.

   rel: foo
   href: bar
   attributes:
      baz: expr(object.getId())

Appears that all the other drivers (XML, annotation) respected expressions in attributes, except YAML driver.

This PR fixes that.

@goetas
Copy link
Collaborator

goetas commented Sep 9, 2019

Thanks a lot! PR looks very good to me!

@goetas goetas merged commit 1ece8c1 into willdurand:master Sep 9, 2019
@goetas
Copy link
Collaborator

goetas commented Sep 9, 2019

Released in https://github.com/willdurand/Hateoas/releases/tag/3.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phpeek @goetas