PHP 8 compatibility #313
Merged
PHP 8 compatibility #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into php_8_compat
|
Contains #312 |
|
Hi all, is there any ETA when this will be merged? |
goetas
reviewed
Jan 12, 2021
composer.json
Outdated
| @@ -17,20 +17,22 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": "^7.2", | |||
| "php": "^7.3 | ^8.0", | |||
There was a problem hiding this comment.
why increasing php from 7.2 to 7.3?
There was a problem hiding this comment.
yep, phpunit 9 requirers >=7.3 https://packagist.org/packages/phpunit/phpunit
There was a problem hiding this comment.
ok, but by using "phpunit/phpunit": "^7 | ^9", we should be able to stay on 7.2 since phpunit 7 requires php 7.1
|
It was dropped by @W0rma but from what I remember phpunit forced that. |
|
Thank you for your work |
|
@ahilles107 @goetas Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adjust tests for phpunit 9, fix broken methods signatures for php8