Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xy-chart][areadifference] pass margin to AreaSeries #150

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

williaster
Copy link
Owner

🐛 Bug Fix

  • Fixes a bug introduced in 🐛[xy-chart] fix top/left tooltip offset #140 for tooltip interactions on <AreaDifferenceSeries /> if <XYChart eventTrigger="series" /> where AreaDifferenceSeries doesn't pass margin to its children. The error is Cannot read property 'left' of undefined

@codecov
Copy link

codecov bot commented Nov 14, 2018

Codecov Report

Merging #150 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #150   +/-   ##
=======================================
  Coverage   80.53%   80.53%           
=======================================
  Files         109      109           
  Lines        2415     2415           
  Branches      568      568           
=======================================
  Hits         1945     1945           
  Misses        290      290           
  Partials      180      180
Impacted Files Coverage Δ
...kages/xy-chart/src/series/AreaDifferenceSeries.jsx 84.37% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f695e4...59cd81e. Read the comment docs.

@williaster williaster merged commit 9064115 into master Nov 14, 2018
@williaster williaster deleted the chris--area-series-fix branch November 14, 2018 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant