Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build][babel] let consumers polyfill #155

Merged
merged 5 commits into from
Nov 28, 2018
Merged

Conversation

williaster
Copy link
Owner

@williaster williaster commented Nov 28, 2018

🏠 Internal

💥 [possibly breaking] Previously we've configured @babel/preset-env useBuiltIns to "usage" which has caused issues with core-js deps. Rather than adding a core-js dep we'll punt on polyfills to consumers.

Note:

  • fixes a bug in 0.0.73 which required consumers to install core-js, now they can install whatever they want
  • this doesn't apply to event-flow because it is bundled as a mini app essentially.

@codecov
Copy link

codecov bot commented Nov 28, 2018

Codecov Report

Merging #155 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #155   +/-   ##
=======================================
  Coverage   80.53%   80.53%           
=======================================
  Files         109      109           
  Lines        2415     2415           
  Branches      568      568           
=======================================
  Hits         1945     1945           
  Misses        290      290           
  Partials      180      180
Impacted Files Coverage Δ
packages/xy-chart/src/utils/brush/Brush.jsx 83.96% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f23385a...d19fda7. Read the comment docs.

@williaster williaster merged commit f70fc62 into master Nov 28, 2018
@williaster williaster deleted the chris--no-polyfill branch November 28, 2018 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant