Use provided bin values for bin domains.

[maxburke]

🏆 Enhancements
If the user provides a set of bin values, and these match the domain of
the data, use these under the assumption that the user has sorted the
bin values according to their preferred order.

[codecov]

Codecov Report

Merging #159 into master will decrease coverage by 0.22%.
The diff coverage is 22.22%.

@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
- Coverage   80.53%   80.31%   -0.23%     
==========================================
  Files         109      109              
  Lines        2415     2423       +8     
  Branches      568      568              
==========================================
+ Hits         1945     1946       +1     
- Misses        290      297       +7     
  Partials      180      180

Impacted Files	Coverage Δ
...ages/histogram/src/utils/computeDomainsFromBins.js	70.83% <22.22%> (-29.17%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c76fa9...1e6a8c1. Read the comment docs.

[codecov]

Codecov Report

Merging #159 into master will decrease coverage by 0.19%.
The diff coverage is 14.28%.

@@            Coverage Diff            @@
##           master     #159     +/-   ##
=========================================
- Coverage   80.53%   80.34%   -0.2%     
=========================================
  Files         109      109             
  Lines        2415     2422      +7     
  Branches      568      568             
=========================================
+ Hits         1945     1946      +1     
- Misses        290      296      +6     
  Partials      180      180

Impacted Files	Coverage Δ
...ages/histogram/src/utils/computeDomainsFromBins.js	73.91% <14.28%> (-26.09%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c76fa9...7976a82. Read the comment docs.

[williaster]

@maxburke thanks for the PR! 🙌

looks like there are some unrelated lint errors in the build for different packages so don't worry about those. it'd be great to have a test for this specific functionality then I'm happy to merge and should be able to get a release out soon thereafter 👍

[maxburke]

@maxburke thanks for the PR!

looks like there are some unrelated lint errors in the build for different packages so don't worry about those. it'd be great to have a test for this specific functionality then I'm happy to merge and should be able to get a release out soon thereafter

Fantastic! I'll get the tests added.

Apologies for adding the built files and the force-push revert; I forked this into an internal Gitlab server and accidentally pushed to the wrong repo :(

[maxburke]

I did add some tests, though I'm not quite sure why the code-coverage report wasn't re-run..? Do you have any further feedback?

[williaster]

thanks @maxburke! there's something funny going on with the code-cov, travis looks 👌 though. will try and get this release out asap after I fix the lint errors that are failing the current build 👍

[williaster]

@maxburke this should be fixed in @data-ui/histogram^0.0.75

[maxburke]

Awesome, thank you!