Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labelOffset to XAxis props #169

Merged
merged 1 commit into from
Feb 25, 2019
Merged

Add labelOffset to XAxis props #169

merged 1 commit into from
Feb 25, 2019

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Feb 25, 2019

🏆 Enhancements

  • Add labelOffset to XAxis props. Use default value of 14 from the underlying vx.

@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #169 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
- Coverage   80.55%   80.51%   -0.05%     
==========================================
  Files         109      109              
  Lines        2422     2422              
  Branches      568      568              
==========================================
- Hits         1951     1950       -1     
  Misses        291      291              
- Partials      180      181       +1
Impacted Files Coverage Δ
packages/xy-chart/src/axis/XAxis.jsx 100% <ø> (ø) ⬆️
packages/xy-chart/src/chart/XYChart.jsx 76.51% <0%> (-0.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d925b34...7f0902f. Read the comment docs.

Copy link
Owner

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, test coverage change isn't a huge issue/we don't test this in YAxis either rn.

@williaster williaster merged commit 07fcfe3 into williaster:master Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants