Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xy-chart): allow rangePadding override #190

Merged
merged 1 commit into from
Sep 24, 2019

Conversation

williaster
Copy link
Owner

🐛 Bug Fix

Fixes #189 by allowing rangePadding override on Axis components.

@codecov
Copy link

codecov bot commented Sep 24, 2019

Codecov Report

Merging #190 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #190   +/-   ##
======================================
  Coverage    80.5%   80.5%           
======================================
  Files         109     109           
  Lines        2432    2432           
  Branches      570     570           
======================================
  Hits         1958    1958           
  Misses        291     291           
  Partials      183     183
Impacted Files Coverage Δ
packages/xy-chart/src/chart/XYChart.jsx 76.51% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00f8a42...fb47653. Read the comment docs.

@williaster williaster merged commit defcdba into master Sep 24, 2019
@williaster williaster deleted the chris--yAxis-rangePadding branch September 24, 2019 00:32
@williaster
Copy link
Owner Author

confirmed fix in demo
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to set XYchart yAxis rangepadding
1 participant