New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[shared] role=button => role=presentation on FocusBlurHandler #97

Merged

williaster merged 1 commit into master from chris--focus-blur-a11y-error

Mar 28, 2018

Owner

williaster commented Mar 28, 2018

[shared]
🐛 Bug Fix

prefer role="presentation" instead of role="button" on <FocusBlurHandler /> to fix this a11y axe violation

tested locally by sym-linking to our internal component library that flags axe violations.


          [shared] role=button => role=presentation on FocusBlurHandler

5e2ea9f

williaster merged commit ac2b828 into master

williaster deleted the chris--focus-blur-a11y-error branch

March 28, 2018 05:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet