fix: absolute paths should not use the guest cwd #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmh
force-pushed
the
fix-absolute-paths
branch
from
e828afc to
9e8a89a
Compare
This is a follow-up to willothy#30. Removing the `vim.loop.fs_realpath` check helps with relative paths that exist in the guest, but it breaks absolute paths. For example, in a neovim terminal ```shell cd /tmp/ vim /tmp/a/file.txt ``` Would concatenate the path to `/tmp//tmp/a/file. I'm guessing checking for the real path was supposed to handle that scenario, it just conflicted with relative paths that matched the host cwd. This commit checks each file to see if it's absolute and avoid prepending the guest cwd.
davidmh
force-pushed
the
fix-absolute-paths
branch
from
9e8a89a to
27d3582
Compare
|
Tested, fix works 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #30.
Removing the
vim.loop.fs_realpathcheck helps with relative paths that exist in the guest, but it breaks absolute paths.For example, in a neovim terminal
cd /tmp/ vim /tmp/a/file.txtWould concatenate the path to
/tmp//tmp/a/file.txtI'm guessing checking for the real path was supposed to handle that scenario, it just conflicted with relative paths that matched the host cwd.
This commit checks each file to see if it's absolute and avoid prepending the guest cwd.