feat: smart open should prefer alternative window #83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently smart open will pick the FIRST window that is "valid" (a window that is not floating and contains a normal buffer, etc.), which can be unintuitive sometimes.
Suppose I have the following window layout and my cursor is at window
B
, and inC
runs ranger in a terminal:If I switch from
B
toC
using<C-w>j
, then open a file from ranger, the current implementation of smart open will open the file inA
, but I expect it to be opened inB
.This PR fixes this issue by picking the alternative window (
B
) if it is valid.