Unique titles for view dashboard (joomla#147)

* Unique titles for view dashboard

* Remove tabs

* Rename $dashboard to $extenssion. Enable sections

* Add comments. Fix positions

* Fix positions. Language Keys as in com_categories

* Redo changes in language files

* Improve Search for language keys

* Code improvement

* Use ApplicationHelper::stringURLSafe()

* oops

* Fix again

* CodeSniffer: Add blank line, remove double space

* CodeSniffer: remove double space

administrator/components/com_cpanel/View/Cpanel/HtmlView.php

@@ -11,6 +11,7 @@
 
 defined('_JEXEC') or die;
 
+use Joomla\CMS\Application\ApplicationHelper;
 use Joomla\CMS\Factory;
 use Joomla\CMS\Helper\ModuleHelper;
 use Joomla\CMS\Language\Text;
@@ -55,17 +56,53 @@ class HtmlView extends BaseHtmlView
 	public function display($tpl = null)
 	{
 		$app = Factory::getApplication();
+		$extension = ApplicationHelper::stringURLSafe($app->input->getCmd('dashboard'));
+
+		$title = Text::_('COM_CPANEL_DASHBOARD_BASE_TITLE');
+
+		$position = ApplicationHelper::stringURLSafe($extension);
+
+		// Generate a title for the view cPanel
+		if (!empty($extension))
+		{
+			$parts = explode('.', $extension);
+
+			$prefix = 'COM_CPANEL_DASHBOARD_';
+			$lang = Factory::getLanguage();
+
+			if (strpos($parts[0], 'com_') === false) 
+			{
+				$prefix .= strtoupper($parts[0]);
+			}
+			else 
+			{
+				$prefix = strtoupper($parts[0]) . '_DASHBOARD';
+
+				// Need to load the language file 
+				$lang->load($parts[0], JPATH_BASE, null, false, true)
+				|| $lang->load($parts[0], JPATH_ADMINISTRATOR . '/components/' . $parts[0], null, false, true);
+				$lang->load($parts[0]);
+			}
+
+			$sectionkey = !empty($parts[1]) ?   '_' . strtoupper($parts[1]) : '';
+			$key = $prefix . $sectionkey . '_TITLE';
+
+			// Search for a component title
+			if ($lang->hasKey($key))
+			{
+				$title = Text::_($key);
+			}
+		}
 
 		// Set toolbar items for the page
-		ToolbarHelper::title(Text::_('COM_CPANEL'), 'home-2 cpanel');
+		ToolbarHelper::title(Text::_($title, 'home-2 cpanel'));
 		ToolbarHelper::help('screen.cpanel');
 
 		// Display the cpanel modules
-		$dashboard = $app->input->getCmd('dashboard');
-		$this->position = $dashboard ? 'cpanel-' . $dashboard : 'cpanel';
+		$this->position = $position ? 'cpanel-' . $position : 'cpanel';
 		$this->modules = ModuleHelper::getModules($this->position);
 
-		$quickicons = $dashboard ? 'icon-' . $dashboard : 'icon';
+		$quickicons = $position ? 'icon-' . $position : 'icon';
 		$this->quickicons = ModuleHelper::getModules($quickicons);
 
 		parent::display($tpl);

administrator/language/en-GB/en-GB.com_content.ini

@@ -3,7 +3,6 @@
 ; License GNU General Public License version 2 or later; see LICENSE.txt, see LICENSE.php
 ; Note : All ini files need to be saved as UTF-8
 
-
 COM_CONTENT="Articles"
 COM_CONTENT_ADD_NEW_MENU_ITEM="New Menu Item"
 COM_CONTENT_ARTICLE_CONTENT="Content"

administrator/language/en-GB/en-GB.com_cpanel.ini

@@ -6,6 +6,13 @@
 COM_CPANEL="Control Panel"
 COM_CPANEL_ADD_DASHBOARD_MODULE="Add dashboard module"
 COM_CPANEL_ADD_MODULE_MODAL_TITLE="Add Module"
+COM_CPANEL_DASHBOARD_BASE_TITLE="Control Panel"
+COM_CPANEL_DASHBOARD_COMPONENTS_TITLE="Control Panel Components"
+COM_CPANEL_DASHBOARD_CONTENT_TITLE="Control Panel Content"
+COM_CPANEL_DASHBOARD_CONTENT_WORKFLOW_TITLE="Control Panel Content Workflow"
+COM_CPANEL_DASHBOARD_MENUS_TITLE="Control Panel Menu"
+COM_CPANEL_DASHBOARD_SYSTEM_TITLE="Control Panel System"
+COM_CPANEL_DASHBOARD_USERS_TITLE="Control Panel Users"
 COM_CPANEL_ERROR_DASHBOARD_TYPE_NOT_SUPPORTED="This dashboard type is not supported."
 COM_CPANEL_MESSAGES_BODYMORE_NOCLOSE="This information area won't appear when you have hidden all the messages."
 COM_CPANEL_MESSAGES_BODY_NOCLOSE="There are important post-installation messages that require your attention."