Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add language filter #48

Closed
wants to merge 1 commit into from
Closed

add language filter #48

wants to merge 1 commit into from

Conversation

alikon
Copy link

@alikon alikon commented Mar 20, 2020

Pull Request for Issue # .

Summary of Changes

added language filter

Testing Instructions

JROOT_URL/api/index.php/v1/content/article?filter[language]=de-DE

Expected result

filter by language

Actual result

Documentation Changes Required

@wilsonge
Copy link
Owner

So I'd deliberately left this one out because it's not the primary attribute of the Resource and I wasn't sure if it should be (i.e. we should filter on the content type primary key as opposed to language code)

@alikon
Copy link
Author

alikon commented Mar 20, 2020

i was testing on a multiligual so i've thinked at it like a missed option.... but yeah let's focus on porting filter on all the core component before

@wilsonge
Copy link
Owner

It's definitely missing and needs to be there before stable. but probably needs a proper discussion

@alikon
Copy link
Author

alikon commented Mar 20, 2020

ok i'll do a new pr

@alikon alikon closed this Mar 20, 2020
@alikon alikon deleted the patch-112 branch March 20, 2020 11:14
@wilsonge
Copy link
Owner

thankyou :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants