add buffer overrun patch

winblues · Jan 22, 2025 · 42fa61a · 42fa61a
1 parent ada25ea
commit 42fa61a
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 28 deletions.
diff --git a/packages/skippy-xd/buffer-overrun.patch b/packages/skippy-xd/buffer-overrun.patch
@@ -0,0 +1,20 @@
+commit 20aa0319d2a6cd21fd2a0ec91c1abdaadc01d94a
+Author: Adam Fidel <[email protected]>
+Date:   Wed Jan 22 07:59:34 2025 -0600
+
+    fix: buffer overrun while writing to fifo
+
+diff --git a/src/skippy.c b/src/skippy.c
+index d8e7dac..8dc9053 100644
+--- a/src/skippy.c
++++ b/src/skippy.c
+@@ -2065,7 +2065,8 @@ load_config_file(session_t *ps)
+     // less efficient, may introduce inconsistent default value, and
+     // occupies a lot more memory for non-string types.
+ 	{
+-		int pipeStrLen = 3;
++		// two -'s, the first digit of uid/xid and null terminator
++		int pipeStrLen = 5;
+
+ 		int uid = getuid();
+ 		{
diff --git a/packages/skippy-xd/skippy-xd.spec b/packages/skippy-xd/skippy-xd.spec
@@ -1,13 +1,13 @@
 Name:           skippy-xd
 Version:        0.9.0
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        A window selector for X11 with Exposé and live preview Alt-Tab effects and more
 
 URL:            https://github.com/felixfung/skippy-xd
 Source:         https://github.com/felixfung/skippy-xd/archive/cb14e598431b93f46073256f603cfd0e6f20e517.zip
 License:        GPL-2.0
 
-Patch0:         uninitialized-vars.diff
+Patch0:         buffer-overrun.diff
 
 BuildRequires:  make
 BuildRequires:  gcc

diff --git a/packages/skippy-xd/uninitialized-vars.diff b/packages/skippy-xd/uninitialized-vars.diff