Streamlining identification #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also adding fix for #154 |
1 task
|
@zsteinmetz, I am pretty happy with this PR, if you have a chance to review and sign off too, that would be great! Trying to Keep PRs relatively small and manageable so we don't end up having that monster PR like the big release one again. |
1 task
Totally agree! |
|
@zsteinmetz Hope you are doing well! Just pinging you again, I got these changes implemented now in the shiny app. If we can push this update to CRAN it will allow me to more easily streamline the update there. |
|
So sorry! It's been quite stressful lately. I'll look into it first thing next week. |
|
Sorry to hear you've been stressed out lately man please let me know if I
can help in any way! Really appreciate you sending this through.
…On Sat, Nov 25, 2023, 5:06 AM Zacharias Steinmetz ***@***.***> wrote:
Merged #157 <#157>
into main.
—
Reply to this email directly, view it on GitHub
<#157 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGMUJU6FN2USMZNUM3JXVMLYGHUNVAVCNFSM6AAAAAA7BSU63OVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRGA3DANRZGAZTIOI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now I think identification is a little convoluted because it always requires that you use preprocessing first to conform the spectra. I want conformation to be a part of the match_spec function too. This configuration will allow us to speed up the processing routine in the app by bypassing the conformation step until we do the match. In many cases, code workflows will also be more succinct because the match_spec function can be used alone. I want to make a new test to make sure that this update conforms to the alternative routine and add this logic into the tutorials.