fix: Ensure the root option provided by the user has higher priority (close #214) #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📖
This pull request ensures that when users provide the
rootoption, it's used consistently when loading configuration files.Background 📜
The
rootuser option was introduced for projects where Vite's root does not match the project root, allowing files to be resolved correctly.When the
windi.config.tsfile was introduced, files were correctly resolved using the user provided root.In #129, the precedence was accidentally inverted when loading configuration files, which means configuration files would be resolved against the Vite root instead (see the first problem described in #214).