Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint and prettier #64

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Fix lint and prettier #64

merged 3 commits into from
Jul 13, 2023

Conversation

northword
Copy link
Collaborator

  • commit acb6cd7, 724a2eb 更新了 eslint major version,新的 eslint 要求 @typescript-eslint/ban-ts-commentallow-with-description 需要是一个对象。

    同时更新了 example.ts 中的 ts-ignore 注释。

  • commit c280874 更新了 prettier major version,新版本默认添加所有的尾随逗号,同时,新版取消了 Node.js v14,v17 的支持。
    https://prettier.io/blog/2023/07/05/3.0.0.html#javascript

    npm install 后需要重新启动 vscode 以让 prettier 工作正常。

  • 让 release-it init 前 lint 代码,或许 build 时候一起?或许手动运行,revert 这次提交就可。

  • 更新依赖

@windingwind windingwind merged commit 18476d9 into windingwind:main Jul 13, 2023
@northword northword deleted the fix-lint branch July 13, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants