Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINDUP-1387 - Allow user to register path and stay on app registration page #465

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

klinki
Copy link
Collaborator

@klinki klinki commented Jun 23, 2017

Allow user to register path and stay on app registration page.

#close WINDUP-1387

Allow user to register path and stay on app registration page.

#close WINDUP-1387
@klinki klinki force-pushed the windup-1378-server-path-add-button branch from aa142da to 5ca28dd Compare June 23, 2017 10:26
@klinki
Copy link
Collaborator Author

klinki commented Jun 23, 2017

It works but Angular throws some exceptions:

ERROR Error: ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value: 'false'. Current value: 'true'.
at viewDebugError (core.es5.js:8611)
at expressionChangedAfterItHasBeenCheckedError (core.es5.js:8589)
at checkBindingNoChanges (core.es5.js:8753)
at checkNoChangesNodeInline (core.es5.js:12307)
at checkNoChangesNode (core.es5.js:12281)
at debugCheckNoChangesNode (core.es5.js:12900)
at debugCheckDirectivesFn (core.es5.js:12802)
at Object.View_RegisterApplicationFormComponent_0.co [as updateDirectives] (RegisterApplicationFormComponent.html:53)

@jsight
Copy link
Member

jsight commented Jun 23, 2017

retest

@klinki
Copy link
Collaborator Author

klinki commented Jun 27, 2017

I tested it again and I still don't know how to fix this issue, but in AOT compiled version it works properly (it doesn't do 2-way change detection as dev. version does).

@klinki
Copy link
Collaborator Author

klinki commented Jul 20, 2017

@jsight I think this one is ready, could you look at it please?

@mareknovotny
Copy link
Contributor

This needs to be discussed with Marc again as his slide about this change/issue was resolved as DONE and we perhaps won't do anything what is not asked :(

@jsight
Copy link
Member

jsight commented Aug 7, 2017

+1 - A design review with Marc on this is needed. It may not be necessary at all now.

@windupgithubbot1
Copy link

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants