Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give control over backtracking or not #75

Closed
2 tasks done
epage opened this issue Jan 26, 2023 · 1 comment · Fixed by #712
Closed
2 tasks done

Give control over backtracking or not #75

epage opened this issue Jan 26, 2023 · 1 comment · Fixed by #712
Labels
A-error Area: error reporting C-enhancement Category: Raise on the bar on expectations M-breaking-change Meta: Implementing or merging this will introduce a breaking change.
Milestone
0.7.0

Comments

@epage
Copy link
Collaborator

epage commented Jan 26, 2023 •
edited
Loading

Please complete the following tasks

winnow version

0.2

Describe your use case

In typos, I never report errors and don't need backtracking vs not

In toml_edit, I want to experiment with not bascktracking by default

Describe the solution you'd like

  • Add a new trait for specifically creating an error in a specific Error Mode and to transition between Error Modes
    • Implement on existing error types
  • Implement ParseError for Err and make the default constructed mode be backtracking
  • Replace direct references to Err with this new trait + ParseError

Alternatives, if applicable

No response

Additional Context

No response
@epage epage added A-error Area: error reporting C-enhancement Category: Raise on the bar on expectations labels Jan 26, 2023
@epage
Copy link
Collaborator Author

epage commented Jan 26, 2023

Between this and #72, we likely won't need or be able to use IResult anymore but just Result

@epage epage pinned this issue Jan 27, 2023
This was referenced Feb 1, 2023
Closed
Merged
@epage epage added the M-breaking-change Meta: Implementing or merging this will introduce a breaking change. label Mar 22, 2023
@epage epage unpinned this issue Dec 19, 2023
@epage epage added this to the 0.7.0 milestone Oct 23, 2024
This was referenced Jan 8, 2025
Merged
Merged
@epage epage mentioned this issue Jan 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-error Area: error reporting C-enhancement Category: Raise on the bar on expectations M-breaking-change Meta: Implementing or merging this will introduce a breaking change.
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

fix!: Make ErrMode optional by using Result epage/winnow
1 participant
@epage