fix!: Make ErrMode optional by using Result

[epage]

To do this, we abstracted the design of ErrMode with ParserError and ModalError traits.

There might be a performance improvement when using ModalResult but definitely one when switching to Result:

$ cargo bench --bench arithmetic
   Compiling winnow v0.6.24 (/home/epage/src/personal/winnow)
    Finished `bench` profile [optimized + debuginfo] target(s) in 22.35s
     Running examples/arithmetic/bench.rs (target/release/deps/arithmetic-30e63a0cfdaed89e)
Gnuplot not found, using plotters backend
direct                  time:   [346.35 ns 347.73 ns 349.06 ns]
                        change: [-17.115% -16.596% -16.100%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
  2 (2.00%) high mild

ast                     time:   [1.5312 µs 1.5389 µs 1.5478 µs]
                        change: [-7.3692% -6.9226% -6.4734%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
  3 (3.00%) high mild
  4 (4.00%) high severe

lexer                   time:   [1.6899 µs 1.6951 µs 1.7003 µs]
                        change: [-18.013% -17.094% -16.141%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 4 outliers among 100 measurements (4.00%)
  2 (2.00%) high mild
  2 (2.00%) high severe

This is also being done to help with cases like #693

BREAKING CHANGE: Added more E: ParserError trait bounds

BREAKING CHANGE: Some error types may need to be wrapped in ErrMode

BREAKING CHANGE: Annotations for ErrMode need to be added when manually inspecting the ModalResult of a parser

BREAKING CHANGE: Parser<I, O, E> bounds need to be updated to Parser<I, O, ErrMode<E>> or ModalParser<I, O, E>

BREAKING CHANGE: ErrMode functions moved to ParserError and ModalError traits

Fixes #75

[coveralls]

Pull Request Test Coverage Report for Build 12953800605

Details

• 129 of 296 (43.58%) changed or added relevant lines in 14 files are covered.
• 16 unchanged lines in 3 files lost coverage.
• Overall coverage increased (+0.4%) to 40.691%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/binary/mod.rs	20	21	95.24%
src/combinator/core.rs	8	10	80.0%
src/combinator/debug/internals.rs	0	5	0.0%
src/stream/mod.rs	0	5	0.0%
src/ascii/mod.rs	13	20	65.0%
src/binary/bits/mod.rs	8	16	50.0%
src/combinator/branch.rs	12	20	60.0%
src/token/mod.rs	18	28	64.29%
src/parser.rs	2	16	12.5%
src/combinator/impls.rs	14	33	42.42%

Files with Coverage Reduction	New Missed Lines	%
src/parser.rs	3	40.49%
src/error.rs	5	22.65%
src/stream/mod.rs	8	24.67%

Totals
Change from base Build 12934277890:	0.4%
Covered Lines:	1296
Relevant Lines:	3185

---

💛 - Coveralls

[epage]

typos ported over without a change