Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid dynamic requires #117

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

blimmer
Copy link
Contributor

@blimmer blimmer commented Dec 9, 2020

This PR is very similar to #113 but retains the lazy-load behavior per @evanw's comment.

This change would enable usage of esbuild and other single-file build processes.

@freben
Copy link

freben commented Jan 30, 2021

@DABH or @marikaner, is this something you think looks good?

We are hitting significant issues with the dynamic imports, and it seems that others are too. In our case the problems started when using mock-fs intests, which broke winston code.

@vitalii-boink
Copy link

is it possible to get it merged?
In my case it's breaking esbuild when bundling AWS CDK lambda's code

@vcfvct
Copy link

vcfvct commented Jun 15, 2021

Can we pls merge this and publish with a new version so that we can bundle tools like esbuild without doing custom hacks.

Thanks!

@vikasgarghb
Copy link

Can this be merged as this is proving to be a blocker?

@vitalii-boink
Copy link

@blimmer is there anything else blocking you from having it merged?

@blimmer
Copy link
Contributor Author

blimmer commented Jun 22, 2021

Not from my perspective - just need someone with permissions to merge and publish.

@vitalii-boink
Copy link

@blimmer do you know anyone with such permissions ? maybe we could tag someone

@blimmer
Copy link
Contributor Author

blimmer commented Jun 24, 2021

Sadly, I do not. This is my first time contributing to this repo.

@vitalii-boink
Copy link

I see some people in this repository, maybe @indexzero, @mattberther, @pose , @chjj , @santigimeno , @mgibeau , @yurijmikhalevich , @ChrisAlderson might help to move to the next step? Thanks in advance!

@Magzter
Copy link

Magzter commented Aug 10, 2021

This would really help us, seems to be held up for a while. Changes look good.

@tgillus
Copy link

tgillus commented Aug 14, 2021

I just ran into this exact issue today when exploring using esbuild for a project at work. I'm looking forward to this being merged and released. Thank you.

@vitalii-boink
Copy link

@yurijmikhalevich are you able to merge this PR?

@empperi
Copy link

empperi commented Aug 27, 2021

Any news on this? Why isn't this merged? It's an old PR proven to be good and it's a blocker for bunch of people?

@yurijmikhalevich
Copy link
Member

@vitalii-boink, nope.

@vitalii-boink
Copy link

in this case maybe @indexzero could help us as creator of Winston ? so many libs depend on this and we cannot use them because of esbuild failure

@muldos
Copy link

muldos commented Aug 27, 2021

+1 : just ran into this bug, and it seems to be the final that prevent my feather express app to run serverless

@empperi
Copy link

empperi commented Sep 5, 2021

Last PR to this project was merged July 11th, 2020. Is this project still alive? Are there anyone left who can actually merge PRs?

@StoutyAlex
Copy link

This would fix all the issues I am facing with winston using eslint

@IceSentry
Copy link

For anyone that needs this fix, the actual code changes are really small, so you can use something like https://www.npmjs.com/package/patch-package to patch it manually

@yurijmikhalevich yurijmikhalevich merged commit fb8c823 into winstonjs:master Sep 22, 2021
@yurijmikhalevich
Copy link
Member

Now I can merge this :) Merged and released as part of v2.3.0. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.