-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid dynamic requires #117
fix: avoid dynamic requires #117
Conversation
@DABH or @marikaner, is this something you think looks good? We are hitting significant issues with the dynamic imports, and it seems that others are too. In our case the problems started when using mock-fs intests, which broke winston code. |
is it possible to get it merged? |
Can we pls merge this and publish with a new version so that we can bundle tools like Thanks! |
Can this be merged as this is proving to be a blocker? |
@blimmer is there anything else blocking you from having it merged? |
Not from my perspective - just need someone with permissions to merge and publish. |
@blimmer do you know anyone with such permissions ? maybe we could tag someone |
Sadly, I do not. This is my first time contributing to this repo. |
I see some people in this repository, maybe @indexzero, @mattberther, @pose , @chjj , @santigimeno , @mgibeau , @yurijmikhalevich , @ChrisAlderson might help to move to the next step? Thanks in advance! |
This would really help us, seems to be held up for a while. Changes look good. |
I just ran into this exact issue today when exploring using esbuild for a project at work. I'm looking forward to this being merged and released. Thank you. |
@yurijmikhalevich are you able to merge this PR? |
Any news on this? Why isn't this merged? It's an old PR proven to be good and it's a blocker for bunch of people? |
@vitalii-boink, nope. |
in this case maybe @indexzero could help us as creator of Winston ? so many libs depend on this and we cannot use them because of esbuild failure |
+1 : just ran into this bug, and it seems to be the final that prevent my feather express app to run serverless |
Last PR to this project was merged July 11th, 2020. Is this project still alive? Are there anyone left who can actually merge PRs? |
This would fix all the issues I am facing with winston using eslint |
For anyone that needs this fix, the actual code changes are really small, so you can use something like https://www.npmjs.com/package/patch-package to patch it manually |
Now I can merge this :) Merged and released as part of |
This PR is very similar to #113 but retains the lazy-load behavior per @evanw's comment.
This change would enable usage of esbuild and other single-file build processes.