Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rejectionHandlers field to LoggingOptions #1857

Closed
wants to merge 1 commit into from
Closed

Add rejectionHandlers field to LoggingOptions #1857

wants to merge 1 commit into from

Conversation

leonardehrenfried
Copy link

Fixes #1801

@leonardehrenfried
Copy link
Author

I realised that someone made the exact same PR: #1847

@synchronos-t
Copy link

@leonardehrenfried, the #1847 is not the same PR. It's adding handleRejections (a boolean), yours is adding rejectionHandlers. I believe both should be added.

@yahyaest
Copy link

are handleRejections and rejectionHandlers added in LoggerOptions in the lastet winston version ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rejectionHandlers type definition does not exist
3 participants
@leonardehrenfried @synchronos-t @yahyaest