Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a list of levels for the Console transport #286

Closed
wants to merge 2 commits into from

Conversation

tooxie
Copy link

@tooxie tooxie commented Jul 29, 2013

This list includes all the levels that should be redirected to stderr instead of stderr.

This is a proper fix for #162 and #163, instead of the terrible decision of hardcoding arbitrary log levels in the code.

@TimBeyer
Copy link

👍
The default behavior introduces subtle bugs.
You could maybe default to at least error but in general this is a much better solution.

Alvaro Mouriño added 2 commits July 30, 2013 13:51
This list includes all the levels that should be redirected to stderr instead of stderr.
@tooxie
Copy link
Author

tooxie commented Jul 30, 2013

@TimBeyer Changed to ['error'] as default.

@indexzero
Copy link
Member

Thank you for your contribution, but this will be addressed in another way in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants