-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing ServerConfig crashes after session expired / logout [WPB-5960] #2354
Merged
mchenani
merged 2 commits into
develop
from
fix/missing-serverconfig-crashes-cherry-pick
Jan 10, 2024
Merged
fix: missing ServerConfig crashes after session expired / logout [WPB-5960] #2354
mchenani
merged 2 commits into
develop
from
fix/missing-serverconfig-crashes-cherry-pick
Jan 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-5960] (#2352) * fix: missing ServerConfig crashes after session expired / logout [WPB-5960] * simplify LogoutCallback * make LogoutCallback suspend * changes after review * make LogoutCallback to become interface to fix tests
mchenani
approved these changes
Jan 10, 2024
ohassine
approved these changes
Jan 10, 2024
Test Results2 009 tests - 809 1 979 ✔️ - 735 11s ⏱️ - 2m 49s Results for commit 98b464b. ± Comparison against base commit 0696b8e. This pull request removes 2818 and adds 2009 tests. Note that renamed tests count towards both.
This pull request removes 104 skipped tests and adds 30 skipped tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick
PR is cherry-picking changes from another banch
echoes: technical-roadmap
Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt.
🚨 Potential breaking changes
👕 size: M
type: bug / fix 🐞
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick from the original PR:
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
Top crashes types currently are the ones related to missing when making some actions.
Causes (Optional)
When session is expired (the app receives 403 when trying to refresh a token) there is an infinite loop, because the app tries to logout - deregister token which results in 401 and it triggers the auth token refresh again resulting in 403 and trying to logout again. After each iteration, emits the same item again, which triggers multiple actions in the whole app and creates a race condition when logging out (session should be invalid but with all the loop iterations in a fraction of a second the app can still get the previous value).
Some logout actions in Android project are not executed when account is logged out from kalium (when session expires, device is removed from another place or account deleted).
Solutions
Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References