fix: crash related to request focus when clicking on last name EditTe…

…xt in CreateAccountDetailsScreen
wireapp · Sep 7, 2023 · 93df038 · 93df038
1 parent fe1dd56
commit 93df038
Showing 1 changed file with 4 additions and 21 deletions.
diff --git a/...in/kotlin/com/wire/android/ui/authentication/create/details/CreateAccountDetailsScreen.kt b/...in/kotlin/com/wire/android/ui/authentication/create/details/CreateAccountDetailsScreen.kt
@@ -122,9 +122,7 @@ private fun DetailsContent(
         ) {
             val keyboardOptions = KeyboardOptions(KeyboardCapitalization.Words, true, KeyboardType.Text, ImeAction.Next)
             val keyboardController = LocalSoftwareKeyboardController.current
-            val focusRequesterFirstName = remember { FocusRequester() }
-            val focusRequesterLastName = remember { FocusRequester() }
-            val focusRequesterTeamName = remember { FocusRequester() }
+            val firstNameFocusRequester = remember { FocusRequester() }
 
             Column(
                 horizontalAlignment = Alignment.CenterHorizontally,
@@ -134,13 +132,6 @@ private fun DetailsContent(
                     .verticalScroll(rememberScrollState())
             ) {
 
-                val requestFocus = remember<(Offset) -> Unit> {
-                    { _ ->
-                        keyboardController?.show()
-                        focusRequesterTeamName.requestFocus()
-                    }
-                }
-
                 Text(
                     text = stringResource(R.string.create_personal_account_details_text),
                     style = MaterialTheme.wireTypography.body01,
@@ -166,7 +157,7 @@ private fun DetailsContent(
                             end = MaterialTheme.wireDimensions.spacing16x,
                             bottom = MaterialTheme.wireDimensions.spacing16x
                         )
-                        .focusRequester(focusRequesterFirstName)
+                        .focusRequester(firstNameFocusRequester)
                         .testTag("firstName"),
                 )
 
@@ -184,10 +175,7 @@ private fun DetailsContent(
                             end = MaterialTheme.wireDimensions.spacing16x,
                             bottom = MaterialTheme.wireDimensions.spacing16x
                         )
-                        .focusRequester(focusRequesterLastName)
                         .testTag("lastName"),
-                    shouldDetectTaps = true,
-                    onTap = requestFocus
                 )
 
                 if (state.type == CreateAccountFlowType.CreateTeam) {
@@ -205,10 +193,7 @@ private fun DetailsContent(
                                 end = MaterialTheme.wireDimensions.spacing16x,
                                 bottom = MaterialTheme.wireDimensions.spacing16x
                             )
-                            .testTag("teamName")
-                            .focusRequester(focusRequesterTeamName),
-                        shouldDetectTaps = true,
-                        onTap = requestFocus
+                            .testTag("teamName"),
                     )
                 }
 
@@ -227,7 +212,6 @@ private fun DetailsContent(
                         WireTextFieldState.Default
                     },
                     autofill = false,
-                    onTap = requestFocus
                 )
 
                 WirePasswordTextField(
@@ -251,12 +235,11 @@ private fun DetailsContent(
                             WireTextFieldState.Error(stringResource(id = R.string.create_account_details_password_error))
                     } else WireTextFieldState.Default,
                     autofill = false,
-                    onTap = requestFocus
                 )
             }
 
             LaunchedEffect(Unit) {
-                focusRequesterFirstName.requestFocus()
+                firstNameFocusRequester.requestFocus()
                 keyboardController?.show()
             }