-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support resource customization #1739
Merged
vitorhugods
merged 2 commits into
release/candidate
from
feat/support_resource_customization
Apr 27, 2023
Merged
feat: support resource customization #1739
vitorhugods
merged 2 commits into
release/candidate
from
feat/support_resource_customization
Apr 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitorhugods
requested review from
tmspzz,
yamilmedina,
MohamadJaara and
ohassine
April 27, 2023 13:52
Build available here. Scroll down to Artifacts! |
Build 1 succeeded. The build produced the following APK's: |
tmspzz
approved these changes
Apr 27, 2023
alexandreferris
approved these changes
Apr 27, 2023
* @return the [NormalizedFlavorSettings], result from the importing of configuration files. | ||
* @return the [BuildTimeConfiguration], result from the importing of configuration files. | ||
*/ | ||
fun getBuildtimeConfiguration( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
fun getBuildtimeConfiguration( | |
fun getBuildTimeConfiguration( |
Maybe? 🤔
vitorhugods
added a commit
that referenced
this pull request
Jul 13, 2023
vitorhugods
added a commit
that referenced
this pull request
Jul 13, 2023
vitorhugods
added a commit
that referenced
this pull request
Jul 13, 2023
tmspzz
pushed a commit
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
The PR Description
What's new in this PR?
Issues
Customers with custom builds need some resources to be overriden.
Solutions
Check if the customization directory also contains a
resources
directory inside of it.If it does, grab all files from inside the
resources
directory and copy them intores
of each flavor, keeping the file structure.Example:
file2.png
will be copied tores/file2.png
file1.png
will be copied tores/mipmap/file1.png
This is applied to all flavors. It doesn't allow flavor-specific resources for custom builds. A new custom build is needed in order to do it.
Testing
Tested manually.
Coverage will be added Soon™.
Test Coverage (Optional)
How to Test
Force a customized build by adding a
custom.json
file:Add a
resources
directory beside thecustom-reloaded.json
file.Its content will be copied to all flavours.
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.