feat: Send Text Formatting message #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build 1 failed. |
alexandreferris
changed the title
Garzas
reviewed
Jun 14, 2023
app/src/main/kotlin/com/wire/android/ui/home/messagecomposer/RichTextOptions.kt
Outdated
Show resolved
Hide resolved
|
Build 2 failed. |
# Conflicts: # kalium
Codecov Report
@@ Coverage Diff @@
## develop #1857 +/- ##
=============================================
- Coverage 37.23% 37.10% -0.13%
Complexity 809 809
=============================================
Files 276 276
Lines 10511 10558 +47
Branches 1378 1390 +12
=============================================
+ Hits 3914 3918 +4
- Misses 6198 6243 +45
+ Partials 399 397 -2
Continue to review full report in Codecov by Sentry.
|
|
Build (beta-debug) available here. Scroll down to Artifacts! |
|
Build (dev-debug) available here. Scroll down to Artifacts! |
|
Build 3 succeeded. The build produced the following APK's: |
alexandreferris
requested review from
a team,
gongracr,
yamilmedina,
mchenani and
ohassine
and removed request for
a team
saleniuk
reviewed
Jun 16, 2023
app/src/main/kotlin/com/wire/android/ui/common/button/WireSecondaryIconButton.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/wire/android/ui/home/messagecomposer/state/MessageComposeInputState.kt
Outdated
Show resolved
Hide resolved
Comment on lines
126
to
145
| @Stable | ||
| data class NewMessage( | ||
| val attachmentOptionsDisplayed: Boolean = false, | ||
| val richTextFormattingOptionsDisplayed: Boolean = false | ||
| ) : MessageComposeInputType() | ||
|
|
||
| @Stable | ||
| data class EditMessage( | ||
| val messageId: String, | ||
| val originalText: String, | ||
| val richTextFormattingOptionsDisplayed: Boolean = false | ||
| ) : MessageComposeInputType() | ||
|
|
||
| @Stable | ||
| data class SelfDeletingMessage( | ||
| val selfDeletionDuration: SelfDeletionDuration, | ||
| val isEnforced: Boolean, | ||
| val attachmentOptionsDisplayed: Boolean = false | ||
| val attachmentOptionsDisplayed: Boolean = false, | ||
| val richTextFormattingOptionsDisplayed: Boolean = false | ||
| ) : MessageComposeInputType() |
There was a problem hiding this comment.
Had to add in each type instead of directly into the sealed class, otherwise the value wouldn't update into the screen.
saleniuk
approved these changes
Jun 19, 2023
|
Build 4 failed. |
|
Build (beta-debug) available here. Scroll down to Artifacts! |
|
Build (dev-debug) available here. Scroll down to Artifacts! |
|
Build 5 succeeded. The build produced the following APK's: |
Garzas
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
No way to send text with formatting options (Bold, Italic, Header)
Causes (Optional)
Not implemented.
Solutions
Created a new
MessageComposeInputTypecalledRichTextFormattingMessage, so when clicking the RichText icon button when typing a (new/edit/ephemeral) message, it will show the text formatting options.Currently some of the logic is living inside the composables, but this will hopefully change as soon as we have the refactor on message composer so we can better split stuff.
Testing
How to Test
Multiple markdowns are accepted.
Attachments (Optional)
|
| 
|