Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hide three dots when conversation not found [WPB-774] #1869

Merged
merged 5 commits into from
Jun 22, 2023
Merged

fix: hide three dots when conversation not found [WPB-774] #1869

merged 5 commits into from
Jun 22, 2023

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Jun 20, 2023 •
edited by github-actions bot
Loading

BugWPB-774 "show more" button on user profile does not open on the first tap

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Information about conversation with user on user profile screen loads after user opens bottom sheet

Causes (Optional)

When I want to open the options on another users profile, the “Show more” button does not react when tapping it for the first time

Solutions

Load conversation info when user open screen and hide tree dots when user don't have any conversation with other user

@Garzas Garzas self-assigned this Jun 20, 2023
@AndroidBob
Copy link
Collaborator

Build 2 failed.

@github-actions
Copy link
Contributor

Unit Test Results

  70 files  ±0    70 suites  ±0   46s ⏱️ +7s
442 tests  - 2  441 ✔️  - 2  1 💤 ±0  0 ❌ ±0 

Results for commit e4b14c8. ± Comparison against base commit 5250b27.

@Garzas Garzas changed the title Fix: hide three dots when conversation not found [WPB-774] fix: hide three dots when conversation not found [WPB-774] Jun 21, 2023
@github-actions
Copy link
Contributor

Build (beta-debug) available here. Scroll down to Artifacts!

@github-actions
Copy link
Contributor

Build (dev-debug) available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3 succeeded.

The build produced the following APK's:

yamilmedina
yamilmedina approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Good job, I might have some doubts later, as I have some changes in federated branch.

@Garzas Garzas added this pull request to the merge queue Jun 22, 2023
Merged via the queue into develop with commit f6df513 Jun 22, 2023
@Garzas Garzas deleted the fix/hide-three-dots-where-conv-not-found branch June 22, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamilmedina yamilmedina yamilmedina approved these changes

@saleniuk saleniuk saleniuk approved these changes

@borichellow borichellow Awaiting requested review from borichellow

Assignees

@Garzas Garzas

Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Garzas @AndroidBob @yamilmedina @saleniuk