fix(RC): start timer when receiving messages

[MohamadJaara]

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

timer not starting when receiving self deleting messages

Solutions

remove an wrong flag for the timer

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

• GitHub link to other pull request

Testing

Test Coverage (Optional)

• I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[vitorhugods]

Business logic on the UI layer 😞

No easy testing, and wrong place overall.

On the past there was a similar situation where I suggested that instead of calling the ViewModel to mark the last read, it should just call a function like notifyLastVisibleMessage on the ViewModel and let the ViewModel do everything that is needed based on that.

This is quite the same.

The if/else should be in the ViewModel. And it shouldn't tell the ViewModel what to do, the function should be neutral. Like onMessageItemVisible instead of startDeletionTimer.

[github-actions]

Unit Test Results

  71 files    71 suites   52s ⏱️
476 tests 475 ✔️ 1 💤 0 ❌

Results for commit be74620.

[github-actions]

Build (dev-debug) available here. Scroll down to Artifacts!

[github-actions]

Build (beta-debug) available here. Scroll down to Artifacts!

[AndroidBob]

Build 1 succeeded.

The build produced the following APK's:

• com.wire.android-vv4.2.0(6839387)(6839387)-staging-compat.apk