feat: add delete account to settings #1888

MohamadJaara · 2023-06-26T22:15:41Z

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

delete account button in account screen

Solutions

implement the UI as described in jira

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

GitHub link to other pull request

Testing

Test Coverage (Optional)

I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

# Conflicts: # app/src/main/kotlin/com/wire/android/di/CoreLogicModule.kt # kalium

AndroidBob · 2023-06-26T22:28:57Z

Build 112 failed.

AndroidBob · 2023-06-27T08:18:15Z

Build 114 failed.

github-actions · 2023-06-27T09:41:29Z

Unit Test Results

  72 files +2   72 suites +2 19s ⏱️ -4s
446 tests +4 445 ✔️ +4 1 💤 ±0 0 ❌ ±0

Results for commit 5a97449. ± Comparison against base commit ec3fc30.

♻️ This comment has been updated with latest results.

AndroidBob · 2023-06-27T09:44:46Z

Build 117 failed.

codecov · 2023-06-27T11:06:22Z

Codecov Report

Merging #1888 (5a97449) into develop (ec3fc30) will increase coverage by 0.07%.
The diff coverage is 84.21%.

@@              Coverage Diff              @@
##             develop    #1888      +/-   ##
=============================================
+ Coverage      36.05%   36.12%   +0.07%     
- Complexity       784      790       +6     
=============================================
  Files            279      281       +2     
  Lines          10682    10698      +16     
  Branches        1398     1399       +1     
=============================================
+ Hits            3851     3865      +14     
- Misses          6447     6449       +2     
  Partials         384      384

Impacted Files	Coverage Δ
...oid/ui/home/settings/account/MyAccountViewModel.kt	`53.65% <0.00%> (ø)`
...gs/account/deleteAccount/DeleteAccountViewModel.kt	`84.61% <84.61%> (ø)`
...android/ui/home/settings/account/MyAccountState.kt	`100.00% <100.00%> (ø)`
...ttings/account/deleteAccount/DeleteAccountState.kt	`100.00% <100.00%> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec3fc30...5a97449. Read the comment docs.

github-actions · 2023-06-27T11:12:30Z

Build (beta-debug) available here. Scroll down to Artifacts!

github-actions · 2023-06-27T11:12:35Z

Build (dev-debug) available here. Scroll down to Artifacts!

AndroidBob · 2023-06-27T11:26:04Z

Build 122 succeeded.

The build produced the following APK's:

com.wire.android-vv4.3.0(6889680)(6889680)-staging-compat.apk

yamilmedina

LGTM! Just added a small suggestion.

app/src/main/kotlin/com/wire/android/util/CamelCase.kt

AndroidBob · 2023-07-02T10:21:42Z

Build 159 failed.

# Conflicts: # app/src/main/res/values/strings.xml # kalium

github-actions · 2023-07-02T11:32:38Z

@MohamadJaara looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop	This PR
6fa0aaffdb4ddd4400076ce4cffe49b62ea421f3	133eef3c5fe7db351ffd0a894f1cadb9a35834fe

Is this intentional?

github-actions · 2023-07-02T11:50:52Z

Build (dev-debug) available here. Scroll down to Artifacts!

github-actions · 2023-07-02T11:51:21Z

Build (beta-debug) available here. Scroll down to Artifacts!

AndroidBob · 2023-07-02T12:01:31Z

Build 160 succeeded.

The build produced the following APK's:

com.wire.android-vv4.3.0(6933098)(6933098)-staging-compat.apk

vitorhugods

Looks pretty good to me.

I'd just consider moving the logic related to account deletion to its own ViewModel.

app/src/main/kotlin/com/wire/android/ui/home/settings/account/MyAccountViewModel.kt

vitorhugods · 2023-07-03T07:59:36Z

app/src/test/kotlin/com/wire/android/util/StringUtilTest.kt

+        val input = "هذا اختبار"
+        val expected = input


Today I've learned

# Conflicts: # kalium

github-actions · 2023-07-03T15:59:43Z

Build (dev-debug) available here. Scroll down to Artifacts!

github-actions · 2023-07-03T15:59:57Z

Build (beta-debug) available here. Scroll down to Artifacts!

AndroidBob · 2023-07-03T16:16:14Z

Build 177 succeeded.

The build produced the following APK's:

com.wire.android-vv4.3.0(6943234)(6943234)-staging-compat.apk

github-actions · 2023-07-03T16:37:55Z

Build (beta-debug) available here. Scroll down to Artifacts!

github-actions · 2023-07-03T16:38:10Z

Build (dev-debug) available here. Scroll down to Artifacts!

AndroidBob · 2023-07-03T16:55:16Z

Build 182 succeeded.

The build produced the following APK's:

com.wire.android-v4.3.0(6943471)(6943471)-staging-compat.apk

MohamadJaara added 2 commits June 27, 2023 00:14

display delete account dialog

b6f380f

trigger CI

5e4c6ae

pull-request-size bot added the size/L label Jun 26, 2023

Merge branch 'develop' into feat/delete_account

ccc1f88

# Conflicts: # app/src/main/kotlin/com/wire/android/di/CoreLogicModule.kt # kalium

unit test

eb6d2c3

detekt

9cac3a4

MohamadJaara added 2 commits June 27, 2023 12:37

fix tests

fc57170

Merge branch 'develop' into feat/delete_account

825f370

MohamadJaara requested review from a team, gongracr, yamilmedina, alexandreferris, borichellow and ohassine and removed request for a team June 27, 2023 11:05

MohamadJaara self-assigned this Jun 27, 2023

yamilmedina reviewed Jul 1, 2023

View reviewed changes

app/src/main/kotlin/com/wire/android/util/CamelCase.kt Outdated Show resolved Hide resolved

vitorhugods reviewed Jul 1, 2023

View reviewed changes

app/src/main/kotlin/com/wire/android/util/CamelCase.kt Outdated Show resolved Hide resolved

MohamadJaara added 3 commits July 2, 2023 12:13

move extension function to StringUtil file and add test

4a75fae

test

42f9fdd

update kalium

876ea1e

Merge branch 'develop' into feat/delete_account

2941490

# Conflicts: # app/src/main/res/values/strings.xml # kalium

MohamadJaara requested review from vitorhugods and yamilmedina July 2, 2023 11:32

saleniuk approved these changes Jul 3, 2023

View reviewed changes

vitorhugods approved these changes Jul 3, 2023

View reviewed changes

MohamadJaara added 3 commits July 3, 2023 17:24

separate delete account logic to its own view model

c2b0358

Merge branch 'develop' into feat/delete_account

1022e1f

# Conflicts: # kalium

detekt

addfee8

MohamadJaara added 3 commits July 3, 2023 18:19

trigger CI

ba3aa52

checkout kalium dev

1c2dd08

Merge remote-tracking branch 'origin/develop' into feat/delete_account

5a97449

MohamadJaara enabled auto-merge July 3, 2023 16:20

MohamadJaara added this pull request to the merge queue Jul 3, 2023

Merged via the queue into develop with commit 8438b3e Jul 3, 2023

MohamadJaara deleted the feat/delete_account branch July 3, 2023 16:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add delete account to settings #1888

feat: add delete account to settings #1888

MohamadJaara commented Jun 26, 2023 •

edited

Loading

AndroidBob commented Jun 26, 2023

AndroidBob commented Jun 27, 2023

github-actions bot commented Jun 27, 2023 •

edited

Loading

AndroidBob commented Jun 27, 2023

codecov bot commented Jun 27, 2023 •

edited

Loading

github-actions bot commented Jun 27, 2023

github-actions bot commented Jun 27, 2023

AndroidBob commented Jun 27, 2023

yamilmedina left a comment

AndroidBob commented Jul 2, 2023

github-actions bot commented Jul 2, 2023

github-actions bot commented Jul 2, 2023

github-actions bot commented Jul 2, 2023

AndroidBob commented Jul 2, 2023

vitorhugods left a comment

vitorhugods Jul 3, 2023

github-actions bot commented Jul 3, 2023

github-actions bot commented Jul 3, 2023

AndroidBob commented Jul 3, 2023

github-actions bot commented Jul 3, 2023

github-actions bot commented Jul 3, 2023

AndroidBob commented Jul 3, 2023

feat: add delete account to settings #1888

feat: add delete account to settings #1888

Conversation

MohamadJaara commented Jun 26, 2023 • edited Loading

PR Submission Checklist for internal contributors

What's new in this PR?

Issues

Solutions

Dependencies (Optional)

Testing

Test Coverage (Optional)

How to Test

Notes (Optional)

Attachments (Optional)

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

AndroidBob commented Jun 26, 2023

AndroidBob commented Jun 27, 2023

github-actions bot commented Jun 27, 2023 • edited Loading

Unit Test Results

AndroidBob commented Jun 27, 2023

codecov bot commented Jun 27, 2023 • edited Loading

Codecov Report

github-actions bot commented Jun 27, 2023

github-actions bot commented Jun 27, 2023

AndroidBob commented Jun 27, 2023

yamilmedina left a comment

Choose a reason for hiding this comment

AndroidBob commented Jul 2, 2023

github-actions bot commented Jul 2, 2023

github-actions bot commented Jul 2, 2023

github-actions bot commented Jul 2, 2023

AndroidBob commented Jul 2, 2023

vitorhugods left a comment

Choose a reason for hiding this comment

vitorhugods Jul 3, 2023

Choose a reason for hiding this comment

github-actions bot commented Jul 3, 2023

github-actions bot commented Jul 3, 2023

AndroidBob commented Jul 3, 2023

github-actions bot commented Jul 3, 2023

github-actions bot commented Jul 3, 2023

AndroidBob commented Jul 3, 2023

MohamadJaara commented Jun 26, 2023 •

edited

Loading

github-actions bot commented Jun 27, 2023 •

edited

Loading

codecov bot commented Jun 27, 2023 •

edited

Loading