fix: avoid refetching broken assets [WPB-2826] #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build 126 failed. |
saleniuk
reviewed
Jun 27, 2023
app/src/main/kotlin/com/wire/android/util/ui/WireSessionImageLoader.kt
Outdated
Show resolved
Hide resolved
|
Build 138 failed. |
saleniuk
approved these changes
Jun 28, 2023
|
Build (beta-debug) available here. Scroll down to Artifacts! |
|
Build (dev-debug) available here. Scroll down to Artifacts! |
yamilmedina
approved these changes
Jun 28, 2023
Comment on lines
+93
to
+94
| val isRetryNeeded = | ||
| ((painter.state as AsyncImagePainter.State.Error).result.throwable as? AssetImageException)?.isRetryNeeded ?: false |
There was a problem hiding this comment.
Nice to see some tailored exceptions 💯
|
Build 139 succeeded. The build produced the following APK's: |
|
Build (beta-debug) available here. Scroll down to Artifacts! |
|
Build (dev-debug) available here. Scroll down to Artifacts! |
|
Build 140 succeeded. The build produced the following APK's: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Where there was issue with fetching images (not found, server issue, no internet connection), they where fetched in infinite loop
Causes (Optional)
Drop of app performance when users uses app with broken assets
Solutions
Add functionality to retry image fetching when there is connection with internet, also remove not found assets from user asset repository